Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a project context picker / choose active context (TFM) #5788

Open
dibarbet opened this issue Jun 13, 2023 · 4 comments
Open

Implement a project context picker / choose active context (TFM) #5788

dibarbet opened this issue Jun 13, 2023 · 4 comments
Assignees
Milestone

Comments

@dibarbet
Copy link
Member

Implement a TFM / project picker that shows up on open files in the vscode editor. The set of active projects comes from the LSP tools host. When that information changes it must be sent back to the LSP tools host.

One possible implementation would be similar to how it works in VS.

A custom LSP command to retrieve the set of active project contexts (e.g. in VS)
A custom UI that shows up on open documents to allow the user to switch between active contexts. Populated by 1
A middle layer that intercepts LSP client requests and adds on the active document project context before passing the request to the server.

@arkalyanms
Copy link
Member

Moving this up since this is a MAUI blocker.

@jasonmalinowski
Copy link
Member

Small implementation note: the steps @dibarbet outlined are reasonable. For the first step, we already have a handler for the VS for Windows command:

https://github.com/dotnet/roslyn/blob/24fbb2ff42b045831ea4814b35ad8688ec49a52b/src/Features/LanguageServer/Protocol/Handler/ProjectContext/GetTextDocumentWithContextHandler.cs

@arkalyanms arkalyanms modified the milestones: Preview 2, GA, Post GA Jul 25, 2023
@dibarbet dibarbet modified the milestones: Post GA, Backlog, Next Aug 2, 2023
@JoeRobich
Copy link
Member

Signature help currently directs user to switch context in the navigation bar. Perhaps this message can be made more clear for users.

Image

@jasonmalinowski
Copy link
Member

Oh hahaha yes we'll need to change that string!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants