Ignore screen size error reported by ps #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3634 +/- ##
==========================================
- Coverage 87.16% 86.92% -0.25%
==========================================
Files 59 59
Lines 1800 1805 +5
Branches 207 208 +1
==========================================
Hits 1569 1569
- Misses 176 181 +5
Partials 55 55
Continue to review full report at Codecov.
|
Pilchie
reviewed
Mar 6, 2020
| @@ -90,6 +90,16 @@ export async function getUnixChildProcessIds(pid: number): Promise<number[]> { | |||
| }); | |||
|
|
|||
| ps.on('error', reject); | |||
|
|
|||
| ps.stderr.setEncoding('utf8'); | |||
There was a problem hiding this comment.
I don't know how this works with TS promises, but do you need to do something about the ps.on('error', reject); on L92 as well?
There was a problem hiding this comment.
I don't think it will be a problem. Looking at the way vscode-node-debug handled error, it is effectively the same
brettfo
approved these changes
May 14, 2020
|
Hooray - will try again when I get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in microsoft/vscode#75932 (comment) we can ignore the screen size error reported on stderr.
May resolve #3580