Respect the newly added Background analysis scope option in OmniSharp #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to dotnet#5998 This ensures that the Background analysis scope option becomes the source of truth for both C# extension and OmniSharp
dibarbet
reviewed
Aug 7, 2023
dibarbet
reviewed
Aug 8, 2023
dibarbet
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5998
This ensures that the Background analysis scope option becomes the source of truth for both C# extension and OmniSharp. We should drive the users to use the below two options even when OmniSharp server is enabled. They are the replacement for the existing options
Enable support for roslyn analyzers, code fixes and rulesetsandAnalyze open documents onlyand enable configuring these separately for compiler and analyzer diagnostics.NOTE: I ran into #6057 quite often while playing around with this space, I'll send a separate Roslyn PR for fixing that issue.