Show toast when project loading fails #6060
Conversation
| @@ -198,6 +199,25 @@ export class RoslynLanguageServer { | |||
| ); | |||
| }); | |||
|
|
|||
| this._languageClient.onNotification(RoslynProtocol.ProjectLoadFailureNotification.type, async (failure) => { | |||
There was a problem hiding this comment.
If we have a bunch of notifications at once are we going to spam the user? Or does VS Code throttle this in some way for us?
There was a problem hiding this comment.
+1. Can we kick off an array of projects and 1 collated exception that failed load instead?
There was a problem hiding this comment.
from testing it looks like only 1 shows at once
There was a problem hiding this comment.
@dibarbet Once that's dismissed though, does the next one appear? Or the other are just ignored?
There was a problem hiding this comment.
the others are ignored. I was OK with that because these just point to the logs which will show all the errors.
dibarbet
force-pushed
the
show_project_load_error
branch
from
6e74f30
to
cee0dbb
Compare
| @@ -198,6 +199,25 @@ export class RoslynLanguageServer { | |||
| ); | |||
| }); | |||
|
|
|||
| this._languageClient.onNotification(RoslynProtocol.ProjectLoadFailureNotification.type, async (failure) => { | |||
There was a problem hiding this comment.
+1. Can we kick off an array of projects and 1 collated exception that failed load instead?
Resolves #6038
Server side - dotnet/roslyn#69424