Show a prompt if we have more than one solution file #6132
Conversation
This prompt is pretty close to what DevKit does in this same case.
|
|
||
| if (chosen) { | ||
| if (chosen.open) { | ||
| vscode.commands.executeCommand('dotnet.openSolution'); |
There was a problem hiding this comment.
Do we also want to update the property or no like Dev Kit? We've been seeing feedback where people do have multiple solutions and might be confused if this does change it.
There was a problem hiding this comment.
@dibarbet had the idea of just adding a third button. With some wordsmithing I think I got them all to fit.
| ), | ||
| { title: vscode.l10n.t('Choose'), action: 'open' }, | ||
| { title: vscode.l10n.t('Choose and set default'), action: 'openAndSetDefault' }, | ||
| { title: vscode.l10n.t('Do not load any'), action: 'disable' } |
| 'Your workspace has multiple Visual Studio Solution files; please select one to get full IntelliSense.' | ||
| ), | ||
| { title: vscode.l10n.t('Choose'), action: 'open' }, | ||
| { title: vscode.l10n.t('Choose and set default'), action: 'openAndSetDefault' }, |
There was a problem hiding this comment.
other option:
'Choose default'
There was a problem hiding this comment.
I thought about that but decided to make it a bit clearer the second button is first button plus something more. But if we have to save room this would proably be where I'd do it.
| @@ -425,6 +425,32 @@ export class RoslynLanguageServer { | |||
| if (solutionUris) { | |||
| if (solutionUris.length === 1) { | |||
| this.openSolution(solutionUris[0]); | |||
There was a problem hiding this comment.
Sorry I'm a bit late to the party. Since we are trying to improve this area, could we also show the solution picker if default solution can't be opened and there's other solution files in the hierarchy?
[Error - 1:58:27 PM] [LanguageServerHost]Microsoft.Build.Exceptions.InvalidProjectFileException: The project file could not be loaded. Could not find file 'c:\Users\gel\source\repos\ConsoleApp16\ConsoleApp16.sln'. c:\Users\gel\source\repos\ConsoleApp16\ConsoleApp16.sln
There was a problem hiding this comment.
@genlu We could, although I'm still curious how you got an error like that in the first place. 😄
This prompt is pretty close to what DevKit does in this same case.