Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates-dotnet-path-configuration-description #6164

Merged
merged 1 commit into from
Aug 18, 2023
Merged

updates-dotnet-path-configuration-description #6164

merged 1 commit into from
Aug 18, 2023

Conversation

dandev486
Copy link
Contributor

Changelog

  • Clarifies that the dotnet path must refer to a diretory (and not to the executable)
  • Portuguese translation of the same setting (PT-BR)

Other

Related to #6068, based on the clarification provided by @dibarbet.
Related to #6161.

@dandev486 dandev486 requested a review from a team as a code owner August 17, 2023 23:57
@dandev486
Copy link
Contributor Author

@dotnet-policy-service agree

dibarbet
dibarbet approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked this time, I'll merge this when the rest of the CI passes. Thanks!!

@dandev486
Copy link
Contributor Author

No problem, and thanks for the support with the original issue!

@dibarbet dibarbet merged commit 1a93c3f into dotnet:main Aug 18, 2023
4 checks passed
@dandev486 dandev486 deleted the updates-dotnet-path-configuration-description branch August 18, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dandev486 @dibarbet