Use dotnet --list-runtimes instead of version from dotnet --info #6175
+58
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck for an appropriate runtime
arkalyanms
approved these changes
Aug 19, 2023
|
I see this changed O# tests. Has this change been tested with O#? |
Only via the O# integration tests. What broke? |
This is what I get for skimming a PR. Changes look good. Sorry for the interruption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6167
The version that the old O# was picking up from dotnet --info actually was the runtime version. This happened to work for many of us because we had .net 8 installed which is higher than .net 7.
Instead of using SDK version and the version output by dotnet --info, we should actually just look at
dotnet --list-runtimes(which is meant to be machine readable) to find a runtime higher than our desired runtime. Adapted from https://devdiv.visualstudio.com/DevDiv/_git/vs-green/pullrequest/491545