Fix tasks.json parsing by switching to jsonc-parser #6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
force-pushed
the
fix_parsing
branch
from
d37486a
to
92047f7
Compare
dibarbet
changed the title
dibarbet
force-pushed
the
fix_parsing
branch
from
92047f7
to
037c432
Compare
dibarbet
force-pushed
the
fix_parsing
branch
from
037c432
to
83ef473
Compare
jasonmalinowski
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we had our own custom code to clean json files. I don't really want to maintain that, so switching to jsonc-parser which tolerates more than the standard nodejs parser (since vscode is more tolerant as well).
Resolves #4377