Fire telemetry if Razor buffers get out of sync, and recover from same #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allisonchou is this all I need to do for telemetry reporting? It seems too easy :) |
allisonchou
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
LGTM!
@allisonchou is this all I need to do for telemetry reporting? It seems too easy :)
I think so? I'm not as familiar with telemetry on the Typescript side of things - @ryzngard would probably know for sure. Does it show up on the GDPR site?
I haven't actually been able to repro the issue to check, since putting the fix in, but I'll try some more. I was mainly wondering if it's okay to just be hooking up the TelemetryReporter like this, and calling methods on it at will, or if there needs to be checks of some kind so we only do it in DevKit |
Can you tell I copied and pasted this bit? :) Co-authored-by: Allison Chou <allichou@microsoft.com>
ryzngard
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the VS Code equivalent of dotnet/razor#9202
Fixes #6488
I'm not sure why this is so easily reproducable for the user reporting the error, but its extremely intermittent for me. I basically hit it twice today, and never again, but I did at least see that we had duplicate HTML content in our generated file when I hit it, so can be sure this is the issue we are running into.
Perhaps a new timing issue with our initialization, now that its not deferred until file open, but with part of Roslyn and the extension still expecting it to be. Hopefully dotnet/razor#9344 will fix those issues.