Add a timeout for downloading razor telemetry #6622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Nov 2, 2023
davidwengier
commented
Nov 2, 2023
| '.razortelemetry', | ||
| 'Microsoft.VisualStudio.DevKit.Razor.dll' | ||
| ); | ||
| if (await util.fileExists(telemetryExtensionPath)) { |
There was a problem hiding this comment.
Moved this all out just because of the await
maryamariyan
reviewed
Nov 2, 2023
maryamariyan
approved these changes
Nov 2, 2023
|
Boy this UI stuff is easier in VS Code than in VS 😛 |
dibarbet
approved these changes
Nov 10, 2023
| this.eventStream.post(new InstallationSuccess()); | ||
| return true; | ||
| } | ||
| await vscode.window.withProgress( |
|
Who wrote that annoying razor formatting test anyway.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6547
The issue these users are having is to do with their proxy settings in VS Code, and is happening inside where we already have error handling for the download, so it seems like node is just stuck downloading. The only recourse I could work out was a timeout, so at least we're not blocking users forever.