Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove https://aka.ms/VSCode-CS-LaunchJson#... #6659

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

gregg-miskelly
Copy link
Contributor

OptionsSchema.json referenced https://aka.ms/VSCode-CS-LaunchJson with a hash link inside the doc. This isn't flexible enough to redirect to https://code.visualstudio.com/docs/csharp/debugger-settings since the names of the page sections are different. So this updates to use unique aka.ms links for each section.

This also fixes gulp generateOptionsSchema which was broken by a previous refactoring of package.json.

OptionsSchema.json referenced `https://aka.ms/VSCode-CS-LaunchJson` with a hash link inside the doc. This isn't flexible enough to redirect to https://code.visualstudio.com/docs/csharp/debugger-settings since the names of the page sections are different. So this updates to use unique aka.ms links for each section.
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fixes gulp generateOptionsSchema which was broken by a previous refactoring of package.json.

I assume it was the re-ordering of the package.json that caused the issue? Would it be worth having a unit test that verifies that the task still roughly works so we don't accidentally break it again?

@gregg-miskelly
Copy link
Contributor Author

This also fixes gulp generateOptionsSchema which was broken by a previous refactoring of package.json.

I assume it was the re-ordering of the package.json that caused the issue? Would it be worth having a unit test that verifies that the task still roughly works so we don't accidentally break it again?

It was broken by #6652. I am not sure if it is worth having a test since:

  • It would probably never be a product bug if it broke, so we are just changing when it gets fixed
  • It has never broken before

If it did become something that broke repeatedly, it would probably be worth it. But at this point I am inclined to think it doesn't matter enough.

@gregg-miskelly gregg-miskelly merged commit 8ec02bb into dotnet:main Nov 13, 2023
13 checks passed
@gregg-miskelly gregg-miskelly deleted the OptionSchemaLinks branch November 13, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants