Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP does not support UpnEndpointIdentity #10

Closed
iamjasonp opened this issue May 13, 2015 · 7 comments
Closed

HTTP does not support UpnEndpointIdentity #10

iamjasonp opened this issue May 13, 2015 · 7 comments
Assignees
@roncain
Labels
UWP
Milestone
1.1.0

Comments

@iamjasonp
Copy link
Member

The ctor currently throws PlatformNotSupportedException
@zhenlan zhenlan added this to the Future milestone Nov 5, 2015
@zhenlan
Copy link
Member

zhenlan commented Jun 8, 2016

With this, this should only be an issue for UWP.

@zhenlan zhenlan added the UWP label Jun 8, 2016
@iamjasonp
Copy link
Member Author

iamjasonp commented Jun 9, 2016 •
edited

This is a little bit more nuanced:

@iamjasonp iamjasonp mentioned this issue Jun 9, 2016
Closed
@zhenlan zhenlan removed the UWP label Jun 9, 2016
@zhenlan zhenlan changed the title Support UpnEndpointIdentity HTTP does not support UpnEndpointIdentity Jun 27, 2016
@zhenlan zhenlan modified the milestones: 1.1.0, Future Jun 27, 2016
@roncain
Copy link
Contributor

roncain commented Sep 13, 2016 •
edited

Tests disabled with Issue(10) now pass for me on Windows when run manually. They fail on UWP, but I think PR #1502 will remove the PNSE and allow us to see if the tests pass in UWP.

@roncain
Copy link
Contributor

roncain commented Sep 19, 2016

Closing because #1502 appears to have fixed this. I will open a new PR that re-enables the tests previously disabled by issue #10.

@roncain roncain closed this as completed Sep 19, 2016
roncain added a commit to roncain/wcf that referenced this issue Sep 19, 2016
@roncain
Re-enable tests disabled by issue 10
93e6e7b 
PR dotnet#1502 fixed issue dotnet#10 by implementing UpnEndpointIdentity.
But 2 tests were still disabled by issue 10, so this PR just
re-enables those tests.  Both require manual setup to run, so
we will not see them pass or fail in CI or VSO.
@roncain roncain mentioned this issue Sep 19, 2016
Merged
@roncain roncain added the UWP label Sep 19, 2016
@roncain roncain reopened this Sep 19, 2016
@roncain
Copy link
Contributor

roncain commented Sep 19, 2016

Reopening -- this issue exists only in UWP, even after PR #1502.

roncain added a commit to roncain/wcf that referenced this issue Sep 19, 2016
@roncain
Re-enable tests disabled by issue 10, except for NET Native.
ec39cef 
PR dotnet#1502 fixed issue dotnet#10 by implementing UpnEndpointIdentity.
But 2 tests were still disabled by issue 10, so this PR just
re-enables those tests.  Both require manual setup to run, so
we will not see them pass or fail in CI or VSO.

These tests still fail in UWP and so remain disabled there.
mconnew added a commit to mconnew/wcf that referenced this issue Sep 21, 2016
@mconnew
Original commit messages in master were:
a55b712 
Fix UpnEndpointIdentity on UWP

Re-enable tests disabled by issue 10, except for NET Native.

PR dotnet#1502 fixed issue dotnet#10 by implementing UpnEndpointIdentity.
But 2 tests were still disabled by issue 10, so this PR just
re-enables those tests.  Both require manual setup to run, so
we will not see them pass or fail in CI or VSO.

These tests still fail in UWP and so remain disabled there.
@zhenlan zhenlan modified the milestones: 1.2.0, 1.1.0 Sep 22, 2016
mconnew added a commit to mconnew/wcf that referenced this issue Sep 22, 2016
@mconnew
Original commit messages in master were:
44466e6 
Fix UpnEndpointIdentity on UWP

Re-enable tests disabled by issue 10, except for NET Native.

PR dotnet#1502 fixed issue dotnet#10 by implementing UpnEndpointIdentity.
But 2 tests were still disabled by issue 10, so this PR just
re-enables those tests.  Both require manual setup to run, so
we will not see them pass or fail in CI or VSO.

These tests still fail in UWP and so remain disabled there.
roncain added a commit to roncain/wcf that referenced this issue Sep 23, 2016
@roncain
Re-enable tests disabled in UWP for issue dotnet#10
3a04e3e
@roncain
Copy link
Contributor

roncain commented Sep 23, 2016

Retesting in UWP showed these tests pass now, so PR #1560 has been opened to re-enable them.

roncain added a commit that referenced this issue Sep 23, 2016
@roncain
Merge pull request #1560 from roncain/reenable-issue-10-tests
b07247f 
Re-enable tests disabled in UWP for issue #10
@roncain
Copy link
Contributor

roncain commented Oct 10, 2016

Closing now that #1560 has been merged. I manually tested this against NET Native running against a self-hosted service running on a 2nd machine, and passing explicit credential in TestProperties.

@roncain roncain closed this as completed Oct 10, 2016
@zhenlan zhenlan modified the milestones: 1.2.0, 1.1.0 Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roncain roncain

Labels
UWP
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@iamjasonp @roncain @zhenlan