Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.ServiceModel.Http v4.10 #4891

Closed
hoerup opened this issue Aug 22, 2022 · 3 comments
Closed

System.ServiceModel.Http v4.10 #4891

hoerup opened this issue Aug 22, 2022 · 3 comments
Assignees
@imcarolwang
Labels
tooling An issues related to any tool shipped from this repo. triaged
Projects
Tooling
Milestone
dotnet-svcutil 2.0.4

Comments

@hoerup
Copy link

hoerup commented Aug 22, 2022 •
edited
Loading

Describe the bug
While trying to update to System.ServiceModel.Http v4.10.0 we now get this new warning (and since our pipelines runs with warnaserror this breaks the pipeline)

error CS0108: 'OurServiceNameClient.CloseAsync()' hides inherited member 'ClientBase<IOurServiceName>.CloseAsync()'. Use the new keyword if hiding was intended.

We have tried to regenerate the client client, even with latest VS2022, but doesn't help ? Any guide on how to proceed?
@marhoi
Copy link

marhoi commented Aug 22, 2022

Same problem here but with System.ServiceModel.Primitives v4.10.0. Same underlying issue though - WCF 3.4.0 (#4865 I guess). Manually adding "new" to a auto generated client class does not feel right.

@HongGit HongGit added this to Awaiting triage in WCF Triage Aug 22, 2022
@HongGit HongGit added this to Needs triage in Tooling via automation Aug 22, 2022
@HongGit
Copy link
Contributor

HongGit commented Aug 22, 2022

The workaround is to delete the OurServiceNameClient.CloseAsync(), and the fix is to fix dotnet-svcutil not to generate 'OurServiceNameClient.CloseAsync()'.

@HongGit HongGit moved this from Needs triage to 2.0.4 in Tooling Aug 22, 2022
@HongGit HongGit removed this from Awaiting triage in WCF Triage Aug 22, 2022
@HongGit HongGit added triaged tooling An issues related to any tool shipped from this repo. and removed triaged labels Aug 22, 2022
@HongGit HongGit added this to the dotnet-svcutil 2.0.4 milestone Aug 24, 2022
@imcarolwang imcarolwang mentioned this issue Sep 19, 2022
Merged
@imcarolwang
Copy link
Contributor

The latest release of dotnet-svcutil tool (2.1.0) fixed the problem in generated code. Closing issue.

Tooling automation moved this from 2.0.4 to Closed Nov 1, 2022
This was referenced Mar 17, 2023
Open
Merged
@0xced 0xced mentioned this issue Aug 31, 2023
Open
@dan-olsen dan-olsen mentioned this issue Jun 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imcarolwang imcarolwang

Labels
tooling An issues related to any tool shipped from this repo. triaged
Projects
Tooling
Closed
Milestone
dotnet-svcutil 2.0.4
Development

No branches or pull requests
4 participants
@hoerup @HongGit @imcarolwang @marhoi