Implement IAsyncDisposable and remove ChainedAsyncResult as it's buggy #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconnew
force-pushed
the
DisposeAsyncSupport
branch
from
fb66b1e
to
25cefd7
Compare
…enHelperAsync to prevent async deadlock on low/single thread sync context
mconnew
force-pushed
the
DisposeAsyncSupport
branch
from
3899f44
to
62d29e6
Compare
HongGit
approved these changes
Aug 4, 2022
Closed
0xced
added a commit
to 0xced/wcf
that referenced
this pull request
Dec 14, 2023
So that channels created through a `ChannelFactory<T>` without inheriting from `ClientBase<T>` can also benefit from the asynchronous disposal improvements introduced in dotnet#4865. Fixes dotnet#5270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
Implements the method described here when using DisposeAsync. It will only handle TimeoutException or CommunicationException (or a derived class), but anything outside of those exceptions are being thrown by user code.
The problem with ChainedAsyncResult was that if you threw an exception in an event handler when closing, it would be get wrapped in a CallbackException, but then rethrown in a way where nothing would catch it and the async Close operation would never complete. I verified the replacement code will cause the exception to reach user code.
I also discovered some dead code so removed that.
This also adds CloseAsync to ClientBase<TChannel>.