Async open improvements for NetTcp #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HongGit
approved these changes
May 23, 2022
…anging SspiSecurityTokenProvider to avoid this when GetTokenAsync is called
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes reduce how often we need to go async when opening a TCP channel. If connecting to
localhost, there's no need to do any DNS lookup. Also changes the entire socket connection stage to use ourSynchronizationContextwhich dispatches task continuations to an IO thread on Windows, and a manually created background thread on Linux/Mac. This prevents thread pool starvation from preventing forward progress on a TCP channel open.Also removed net5.0 as test target and added net7.0. This required modifying of global.json to add net6.0 as a restored SDK as dotnet maestro updated it to use .net 7.0 preview so we were no longer installing .net6.0 SDK.