Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-svcutil: optimize the referenced wcf package version and add test. #5519

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

dotnet-svcutil: optimize the referenced wcf package version and add test. #5519

wants to merge 3 commits into from

Conversation

imcarolwang
Copy link
Contributor

@imcarolwang imcarolwang commented Apr 30, 2024 •
edited
Loading

Addresses #5499.

Description:

  1. Correctly resolve netstandard2.0 if the TFM moniker string was passed from VS (WCF CS Tool)
  2. Create clear table mapping between .net target version and wcf package version
  3. Add only the common wcf references for version 6.2 and 8.0 packages, update corresponding test baselines
  4. Improve wcf assembly reference condition for .net framework target (use $(TargetFramework.StartsWith('net4') instead of getting the first .net target and check for equality, this will fix bug when there're multiple .net framework 4.x targets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@imcarolwang