[release/6.1] dotnet-svcutil: port 2 more PRs from main branch #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support referenced assembly type reuse for multi-target project * Resolve reabse conflict. * rebase and fix test issue. * Apply workaround for reusing WindowsAppSDK pkg types in maui 7.0-xxx project * Rebase and resolve conflicts.
HongGit
reviewed
May 19, 2024
| // this.MSBuildProj.TargetFramework = targetFramework; | ||
| //} | ||
| var targetFramework = frameworkInfo.FullName; | ||
| if (isSupportedTFM && frameworkInfo.Name != FrameworkInfo.Netstandard && frameworkInfo.Version.CompareTo(new Version(6, 0)) >= 0) |
There was a problem hiding this comment.
We will still support net standard.
There was a problem hiding this comment.
netstandard support remains both before and after the change. The bootstrapper project serves the purpose of type reuse and is required to be an executable target, hence it cannot be netstandard. With this update, the bootstrapper project now targets the default .NET Core version installed on the machine when the user project targets netstandard. Previously, the bootstrapper project inadvertently used the default .NET Core version installed on the machine regardless of the target of the user project, which was unintended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc: @HongGit.