dotnet-svcutil: update NamedPipeMetadataImporter to remove the internal asset folder. #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HongGit
reviewed
Jun 17, 2024
...crosoft.Svcutil.NamedPipeMetadataImporter/Microsoft.Svcutil.NamedPipeMetadataImporter.csproj
Outdated
Show resolved
Hide resolved
HongGit
reviewed
Jun 26, 2024
...crosoft.Svcutil.NamedPipeMetadataImporter/Microsoft.Svcutil.NamedPipeMetadataImporter.csproj
Outdated
Show resolved
Hide resolved
It's possible to remove the extra folder 'InternalAssets', and the necessary contents would be organized with subfolders such as net6.0/net8.0/net462 under the same path. Are there any concerns you foresee with this updated structure? |
imcarolwang
force-pushed
the
RemoveInternalAssets
branch
from
ed08d0f
to
e5b79be
Compare
HongGit
reviewed
Jul 7, 2024
imcarolwang
force-pushed
the
RemoveInternalAssets
branch
from
2cd4765
to
89e7c2d
Compare
HongGit
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.