-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Update dependencies from dotnet/wpf #3852
[release/8.0] Update dependencies from dotnet/wpf #3852
Conversation
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-rc.2.23462.7 -> To Version 8.0.0-rc.2.23463.3 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 8.0.0-rc.1.23419.5 -> To Version 8.0.0-rc.2.23463.2 (parent: Microsoft.DotNet.Wpf.GitHub
See following build issues: .dotnet\sdk\8.0.100-preview.7.23376.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.CrossGen.targets#L470 @azure-pipelinesazure-pipelines @azure-pipelinesazure-pipelines @mmitche / @wtgodbe / @marcpopMSFT, @singhashish-wpf , any pointers? |
Notification for subscribed users from https://github.com/dotnet/wpf:@dotnet/wpf-developers,@dotnet/dotnet-winforms Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-rc.2.23462.7 -> To Version 8.0.0-rc.2.23464.2 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 8.0.0-rc.1.23419.5 -> To Version 8.0.0-rc.2.23463.2 (parent: Microsoft.DotNet.Wpf.GitHub
I don't know. Anyone from the runtime team know about this? @ViktorHofer |
@mangod9 thoughts?
|
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-rc.2.23462.7 -> To Version 8.0.0-rc.2.23464.3 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 8.0.0-rc.1.23419.5 -> To Version 8.0.0-rc.2.23464.2 (parent: Microsoft.DotNet.Wpf.GitHub
We will investigate. Assume the crossgen failure repros consistently? |
Adding @agocke as well. I am able to repro the failure with the following commandline on Release builds:
Interestingly it doesnt appear to repro without NativeAOT-ed crossgen2. I dont notice any recent changes in crossgen2, so wondering if a NativeAOT change is causing this. |
Also adding @trylek @davidwrighton for visibility here since its a crossgen2 failure. |
@MichalStrehovsky Any chance this could be caused by dotnet/runtime#91660, and would be fixed by the revert? |
We're seeing the same thing in aspnetcore: dotnet/aspnetcore#50362 (comment) |
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-rc.2.23462.7 -> To Version 8.0.0-rc.2.23464.4 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 8.0.0-rc.1.23419.5 -> To Version 8.0.0-rc.2.23464.4 (parent: Microsoft.DotNet.Wpf.GitHub
My current bet is this is caused by dotnet/runtime#91788 |
@jkotas Is the above a possible side effect of that change? |
Never mind -- that was main only. It was likely the reflection metadata change. I think this might just be solved by more recent PR flow. I'll investigate the runtime flow. |
Yes, this should be fixed by dotnet/runtime#91988 |
And it looks like we just haven't had a successful build since that one went in. I've queued a retry. |
New build is out -- this should auto-flow now. |
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-rc.2.23462.7 -> To Version 8.0.0-rc.2.23464.5 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Internal.Runtime.WindowsDesktop.Transport,Microsoft.Private.Winforms,Microsoft.NETCore.App.Ref,Microsoft.Private.Winforms,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.Private.Winforms,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.Private.Winforms,Microsoft.Win32.Registry.AccessControl,Microsoft.Private.Winforms,Microsoft.Win32.SystemEvents,Microsoft.Private.Winforms,System.CodeDom,Microsoft.Private.Winforms,System.ComponentModel.Composition,Microsoft.Private.Winforms,System.Configuration.ConfigurationManager,Microsoft.Private.Winforms,System.Data.Odbc,Microsoft.Private.Winforms,System.Data.OleDb,Microsoft.Private.Winforms,System.Diagnostics.EventLog,Microsoft.Private.Winforms,System.Diagnostics.PerformanceCounter,Microsoft.Private.Winforms,System.DirectoryServices.AccountManagement,Microsoft.Private.Winforms,System.DirectoryServices.Protocols,Microsoft.Private.Winforms,System.DirectoryServices,Microsoft.Private.Winforms,System.IO.Packaging,Microsoft.Private.Winforms,System.IO.Ports,Microsoft.Private.Winforms,System.Management,Microsoft.Private.Winforms,System.Reflection.Context,Microsoft.Private.Winforms,System.Runtime.Caching,Microsoft.Private.Winforms,System.Security.Cryptography.Pkcs,Microsoft.Private.Winforms,System.Security.Cryptography.ProtectedData,Microsoft.Private.Winforms,System.Security.Cryptography.Xml,Microsoft.Private.Winforms,System.Security.Permissions,Microsoft.Private.Winforms,System.ServiceModel.Syndication,Microsoft.Private.Winforms,System.ServiceProcess.ServiceController,Microsoft.Private.Winforms,System.Speech,Microsoft.Private.Winforms,System.Text.Encoding.CodePages,Microsoft.Private.Winforms,System.Threading.AccessControl,Microsoft.Private.Winforms,System.ComponentModel.Composition.Registration,System.Drawing.Common From Version 8.0.0-rc.1.23419.5 -> To Version 8.0.0-rc.2.23464.6 (parent: Microsoft.DotNet.Wpf.GitHub
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/wpf