Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The visual basic code source does not match any code style #11136

Open
paul1956 opened this issue Mar 28, 2024 · 2 comments
Open

The visual basic code source does not match any code style #11136

paul1956 opened this issue Mar 28, 2024 · 2 comments
Assignees
Labels
area-VisualBasic enhancement Product code improvement that does NOT require public API changes/additions Priority:3 Work that is nice to have

Comments

@paul1956
Copy link
Contributor

Background and motivation

I would like to clean up the style of the code using automatic tools that understand VB and manually where tools don't exist.

So remove Options from Source file and move to project file, the project file already has 2 of 3 settings used in source.
Change Option Explicate On which is true in all but a few files.
Indent the Text of XML comments by 1 space.
Remove blank lines between Class and Namespace
Organize imports, Privates, Publics, according to tools available options.

None of this involves any code changes but will make it easier to test and comprehend with the possible exception of 1 function call that already is causing a suggestion.

API Proposal

N/A

API Usage

N/A

Alternative Designs

I could do this as 1 PR or first clean up formatting issues and then reorganize the code layout or I could only do this to files I am already touching or any combination.

Getting nit comments about formatting files that started out as a mess and still are doesn't make PR reviews fun.

Risks

Low as no code is being changed

Will this feature affect UI controls?

No

@paul1956 paul1956 added api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation untriaged The team needs to look at this issue in the next triage labels Mar 28, 2024
@KlausLoeffelmann
Copy link
Member

+1!!!

This seems like a really good idea!

@paul1956
Copy link
Contributor Author

paul1956 commented Apr 3, 2024

@KlausLoeffelmann My updated PR #10684 with Tests only now has all the changes in formatting also. I can change comment.
It also has more test coverage of the VB Code. Still have issue with there being 2 VB Utils classes that conflict If I try to expose the VB code to tests but it don't effect that PR.

@merriemcgaw merriemcgaw removed the untriaged The team needs to look at this issue in the next triage label Apr 3, 2024
@merriemcgaw merriemcgaw added Priority:2 Work that is important, but not critical for the release area-VisualBasic Priority:3 Work that is nice to have and removed Priority:2 Work that is important, but not critical for the release labels Apr 3, 2024
@Tanya-Solyanik Tanya-Solyanik added enhancement Product code improvement that does NOT require public API changes/additions and removed api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-VisualBasic enhancement Product code improvement that does NOT require public API changes/additions Priority:3 Work that is nice to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants