Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Hosting file to HostingServices #11173

Closed
wants to merge 24 commits into from

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Apr 6, 2024

Separate Interface into separate file
Rename Hosting file to match Class Name
Fix related spelling errors.

Addresses #11136 for Hosting

Proposed changes

Refactor Hosting, separate interface into separate file, fix related spelling errors.

Customer Impact

None

Regression?

No

Risk

None

Test methodology

Existing code coverage covers this code

Visual Basic Code cleanup

Microsoft Reviewers: Open in CodeFlow

Fix related spelling errors
@paul1956 paul1956 requested a review from a team as a code owner April 6, 2024 23:48
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 61.71429% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 74.29326%. Comparing base (5a78c8b) to head (a9efd49).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11173         +/-   ##
===================================================
+ Coverage   74.28707%   74.29326%   +0.00619%     
===================================================
  Files           3011        3014          +3     
  Lines         625588      625622         +34     
  Branches       46542       46543          +1     
===================================================
+ Hits          464731      464795         +64     
+ Misses        157467      157442         -25     
+ Partials        3390        3385          -5     
Flag Coverage Δ
Debug 74.29326% <61.71429%> (+0.00619%) ⬆️
integration 18.33352% <34.84848%> (-0.00038%) ⬇️
production 46.89752% <49.24242%> (+0.00963%) ⬆️
test 97.04185% <100.00000%> (+0.00033%) ⬆️
unit 43.81177% <14.39394%> (-0.01474%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Reorginize File to match VB reccommendation (private, friend public)
@paul1956
Copy link
Contributor Author

paul1956 commented Apr 8, 2024

@KlausLoeffelmann In order at add tests to VB code VisibleToTest attribute must be set but setting it causes an ambiguous reference to "Utils" that I don't know how to resolve.

@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label Apr 21, 2024
@paul1956
Copy link
Contributor Author

This is largely duplicated by Code Cleanup PR except for one minor file change. I am going to close

@paul1956 paul1956 closed this Apr 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Apr 23, 2024
@paul1956 paul1956 deleted the Refactor-Hosting branch April 29, 2024 01:08
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants