Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentDesigner - InitializeNewComponent/InitializeExistingComponent issues #1395

Closed
MrB0nd opened this issue Jul 16, 2019 · 7 comments · Fixed by #4860
Closed

ComponentDesigner - InitializeNewComponent/InitializeExistingComponent issues #1395

MrB0nd opened this issue Jul 16, 2019 · 7 comments · Fixed by #4860
Labels
area-DesignerSupport tenet-compatibility Incompatibility with previous versions or with WinForms for .NET Framework

Comments

@MrB0nd
Copy link

MrB0nd commented Jul 16, 2019

  • .NET Core Version: 3.0.100-preview8-013006
  • Have you experienced this same bug with .NET Framework?: No

I have a question about the InitializeNewComponent and InitializeExistingComponent methods of the ComponentDesigner class.
 
In .NET Framework, the InitializeNewComponent method implementation contains some code related to DesignerActionUIService. Also InitializeNewComponent calls the OnSetComponentDefaults method that sets the value of the DefaultProperty for the component. InitializeExistingComponent calls the InitializeNonDefault method that does nothing.
 
In .NET Core InitializeNewComponent calls the InitializeNonDefault method. InitializeExistingComponent throws NotImplementedException.
 
So, my questions are:

  1. Is the InitializeExistingComponent method implementation going to change in .NET Core?
  2. Is the Site.Name property going to be assigned as the DefaultProperty value in the .NET Core implementation of the InitializeNewComponent method?
@MrB0nd
Copy link
Author

MrB0nd commented Jul 23, 2019

@merriemcgaw @RussKie Any updates on this?

@merriemcgaw merriemcgaw added 💥 regression-preview Regression from a preview release tenet-compatibility Incompatibility with previous versions or with WinForms for .NET Framework labels Jul 24, 2019
@merriemcgaw merriemcgaw modified the milestones: 3.0.0-Preview9, 3.1 Jul 24, 2019
@merriemcgaw
Copy link
Member

Sorry for the delay @MrB0nd . We're looking at the issue, and I think we're going to be able to address it in 3.1 by porting the remaining pieces of ComponentDesigner class to Core. We're unfortunately a bit overloaded to be certain we can get this in 3.0, but we expect that 3.1 is likely.

@merriemcgaw
Copy link
Member

@MrB0nd can you tell us a bit more about the customer scenario here? If we know what you're trying to enable here we may have better guidance for you.

@merriemcgaw merriemcgaw modified the milestones: 3.1, 5.0 Oct 14, 2019
@MrB0nd
Copy link
Author

MrB0nd commented Oct 17, 2019

@merriemcgaw
This comes from our process of porting the DevExpress End-User Report Designer component to .NET Core 3. Our visual report designer has visual report controls inherited from the Component and their designers inherited from the ComponentDesigner class. We have a custom implementation of IDesignerHost and other design time facilities, so the component integrated into an app simulates the Visual Studio design time experience. Now, we see different behavior of our component depending on the target platform (.NET Core 3 and .NET Framework).

We would like to have consistent behavior of our component, regardless of whether it is .NET Core 3 or .NET Framework.

@merriemcgaw
Copy link
Member

Investigating for 6.0

@merriemcgaw merriemcgaw modified the milestones: 5.0, 6.0 Sep 9, 2020
@RussKie RussKie added area-DesignerSupport and removed 💥 regression-preview Regression from a preview release labels Mar 10, 2021
@ghost ghost added the 🚧 work in progress Work that is current in progress label Apr 29, 2021
@ghost ghost removed the 🚧 work in progress Work that is current in progress label May 14, 2021
@RussKie RussKie removed this from the 6.0 milestone May 14, 2021
@RussKie
Copy link
Member

RussKie commented May 14, 2021

The ported functionality will be available in .NET 6.0 Preview5. Please raise new issues for any further missing functionality. The sooner we know the higher change we get it addressed before .NET 6.0 GA.
Thanks

@Marie-Shi
Copy link

Verified this issue with .NET 6.0.100-preview.5.21276.15 from Release/6.0.1XX-preview5 branch of https://github.com/dotnet/installer, it is fixed, now those two methods InitializeNewComponent/InitializeExistingComponent have been implemented in Core.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-DesignerSupport tenet-compatibility Incompatibility with previous versions or with WinForms for .NET Framework
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants