Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port missing designer infra #4860

Merged
merged 18 commits into from
May 14, 2021
Merged

Port missing designer infra #4860

merged 18 commits into from
May 14, 2021

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Apr 29, 2021 •
edited
Loading

❗ Do not squash merge!
⚠️ Review commit-by-commit

Resolves #4908
Fixes #1395
Fixes #2573
Fixes #4456
Fixes #4886
Fixes #4887
Fixes AB#1314797
Contributes to #2411

Proposed changes

.NET codebase provides the following designers:

In addition to the existing designers, the following designers are being ported and/or corrected:

  • System.Windows.Forms.Design.ButtonBaseDesigner
  • System.Windows.Forms.Design.ComboBoxDesigner
  • System.Windows.Forms.Design.ControlDesigner
  • System.Windows.Forms.Design.DocumentDesigner - functionality restored
  • System.Windows.Forms.Design.GroupBoxDesigner
  • System.Windows.Forms.Design.LabelDesigner
  • System.Windows.Forms.Design.ListBoxDesigner
  • System.Windows.Forms.Design.ListViewDesigner
  • System.Windows.Forms.Design.PanelDesigner
  • System.Windows.Forms.Design.ParentControlDesigner - functionality restored
  • System.Windows.Forms.Design.PictureBoxDesigner
  • System.Windows.Forms.Design.RadioButtonDesigner
  • System.Windows.Forms.Design.RichTextBoxDesigner
  • System.Windows.Forms.Design.ScrollableControlDesigner - functionality restored
  • System.Windows.Forms.Design.TextBoxDesigner
  • System.Windows.Forms.Design.TreeViewDesigner
  • System.Windows.Forms.Design.UpDownBaseDesigner
  • System.Windows.Forms.Design.UserControlDocumentDesigner

The functionality has been verified via the awesome sample authored by Paolo Foti.

Screenshots

After

designer-demo

Test methodology

  • manual
  • new tests to validate necessary types are type forwarded
Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie added this to the 6.0 Preview5 milestone Apr 29, 2021
@RussKie RussKie requested a review from a team as a code owner April 29, 2021 12:36
@ghost ghost assigned RussKie Apr 29, 2021
@RussKie
Copy link
Member Author

RussKie commented Apr 29, 2021

Please note: due to the sheer size of the ported code and existing time constraints I will not be responding to requests to refactor code, e.g. to rename variables or invert if statements. Such refactors can be done later.

@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Apr 29, 2021 •
edited
Loading

If AxDesigner is not to be ported, is it possible to get rid of a dependency on AxToolboxItem?

Do we need a comment that justifies why BinaryFormatter is used in our code?

@RussKie RussKie mentioned this pull request Apr 30, 2021
Closed
@RussKie RussKie force-pushed the fix_4456_port_missing_designer_infra branch from 7b95182 to fe86aa4 Compare April 30, 2021 01:59
@RussKie
Copy link
Member Author

RussKie commented Apr 30, 2021

Do we need a comment that justifies why BinaryFormatter is used in our code?

I don't think so. We have suppressions in place.

@RussKie RussKie force-pushed the fix_4456_port_missing_designer_infra branch 3 times, most recently from 30a296b to c67936a Compare April 30, 2021 04:51
@RussKie

This comment has been minimized.

Sign in to view
This was referenced May 11, 2021
Closed
Closed
Closed
@RussKie RussKie force-pushed the fix_4456_port_missing_designer_infra branch from 207a307 to 210dbec Compare May 12, 2021 07:04
@RussKie
Copy link
Member Author

RussKie commented May 13, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@RussKie RussKie force-pushed the fix_4456_port_missing_designer_infra branch from 210dbec to 16339d5 Compare May 14, 2021 00:09
@RussKie RussKie force-pushed the fix_4456_port_missing_designer_infra branch from 16339d5 to 7c7f0c3 Compare May 14, 2021 00:10
@RussKie RussKie force-pushed the fix_4456_port_missing_designer_infra branch from 7c7f0c3 to 1533040 Compare May 14, 2021 01:19
@RussKie RussKie force-pushed the fix_4456_port_missing_designer_infra branch from 1533040 to 2d30e86 Compare May 14, 2021 01:33
@RussKie RussKie merged commit 23cdacd into dotnet:main May 14, 2021
@RussKie RussKie deleted the fix_4456_port_missing_designer_infra branch May 14, 2021 02:15
This was referenced May 14, 2021
Closed
Open
@SenthilKumaranRajan
Copy link

Some companies providing a smart tag in Net50

https://www.telerik.com/blogs/dotnet-conf-2020-telerik-ui-for-winforms-wpf-officially-supports-dotnet-5

If smart tag is possible in net 5. Then please suggest how can we do this?

@weltkante
Copy link
Contributor

weltkante commented May 31, 2021 •
edited
Loading

Last I heared they partnered with Microsoft and developed their designers under NDA. Unless I missed the release the WinForms team is still working on support and documentation for everyone else.

[edit] duplicating questions makes it hard to respond, probably should continue discussion in #4887 or a new issue/discussion thread

@ghost ghost locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DustinCampbell DustinCampbell Awaiting requested review from DustinCampbell

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

@KlausLoeffelmann KlausLoeffelmann Awaiting requested review from KlausLoeffelmann

@Tanya-Solyanik Tanya-Solyanik Awaiting requested review from Tanya-Solyanik

@dreddy-work dreddy-work Awaiting requested review from dreddy-work

Assignees

@RussKie RussKie

Labels
area-DesignerSupport
Projects
None yet
Milestone
6.0 Preview5
4 participants
@RussKie @Tanya-Solyanik @SenthilKumaranRajan @weltkante