SR.Designer.cs is public API

[danmoseley]

src\System.Windows.Forms.Design\src\Resources\SR.Designer.cs contains the strings for Winforms implementation, but it is currently a public class which means we would be shipping it as public API and need to document it, not break it, etc.

It should be internal like similar classes in CoreFX (although in CoreFX it's generated in the build)

namespace System.Windows.Forms.Design.Resources {
    using System;
...
    public class SR {

[danmoseley]

This is showing up as "must be documented" in our tooling which is why I noticed it

[merriemcgaw]

Thanks @danmosemsft . I'll have @RussKie take a look. That spreadsheet scared me!

[weltkante]

@merriemcgaw I don't think that SR should be documented, it should be made internal like @danmosemsft suggested. All the SR classes are internal in Desktop Framework too, I don't see why they should start to be public.

[RussKie]

@weltkante I think you may have misread Merrie's response.
We're turning it internal like everything else.

[weltkante]

I was referring to the 'documentation' tag.

[danmoseley]

thanks @RussKie

cc @carlossanlop