Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] CheckedListBox selected item has an incorrect color #3628

Closed
vladimir-krestov opened this issue Jul 22, 2020 · 4 comments · Fixed by #3629
Closed

[Regression] CheckedListBox selected item has an incorrect color #3628

vladimir-krestov opened this issue Jul 22, 2020 · 4 comments · Fixed by #3629
Assignees
@JeremyKuhne
Labels
🪲 bug Product bug (most likely) 💥 regression-preview Regression from a preview release

Comments

@vladimir-krestov
Copy link
Contributor

  • Regression from a6a308f
  • .NET Core Version: 5.0
  • Have you experienced this same bug with .NET Framework?: No

Problem description:

  • If to select some CheckedListBox item it will have an incorrect background color.
    image

Expected behavior:

  • CheckedListBox selected item has a color as before
    image

Minimal repro:

  • Create a .Net 5.0 app using the latest master branch dlls (Or just run WinformsControlsTest project - MultipleControls form)
  • Add a CheckedListBox with items to the form
  • Run the app and select some item
@vladimir-krestov vladimir-krestov added 💥 regression-preview Regression from a preview release 🪲 bug Product bug (most likely) labels Jul 22, 2020
@vladimir-krestov
Copy link
Contributor Author

vladimir-krestov commented Jul 22, 2020 •
edited by RussKie

@JeremyKuhne, could you please take a look at this regression bug? It was added in a6a308f (PR #3553)
I think you know how to fix it. Could you please assign it to you and fix it?

@Vino-Wang, could you please test it using the latest master branch dlls if it possible and approve this bug?

FYI: @SergeySmirnov-Akvelon, @RussKie

@JeremyKuhne JeremyKuhne self-assigned this Jul 22, 2020
@JeremyKuhne
Copy link
Member

I'll fix it shortly

JeremyKuhne added a commit to JeremyKuhne/winforms that referenced this issue Jul 22, 2020
@JeremyKuhne
Set the color when drawing text in CheckedListBox.
7f6d53e 
Didn't actually set a color for the GDI case. Add an assert to FillRectangle to try and flush out this sort of mistake earlier.

Fixes dotnet#3628
@JeremyKuhne JeremyKuhne mentioned this issue Jul 22, 2020
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Jul 22, 2020
JeremyKuhne added a commit that referenced this issue Jul 22, 2020
@JeremyKuhne
Set the color when drawing text in CheckedListBox. (#3629)
174a8f4 
Didn't actually set a color for the GDI case. Add an assert to FillRectangle to try and flush out this sort of mistake earlier.

Fixes #3628
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Jul 22, 2020
@vladimir-krestov
Copy link
Contributor Author

Thank you so much for the hotfix. It works well now. 👍

@Jessie-Zhang01
Copy link

Verified this issue with .Net 6.0.100-alpha.1.20420.20 from Master branch, this issue is fixed. CheckedListBox selected item has a color as before.
image

@ghost ghost locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JeremyKuhne JeremyKuhne

Labels
🪲 bug Product bug (most likely) 💥 regression-preview Regression from a preview release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set the color when drawing text in CheckedListBox. JeremyKuhne/winforms
3 participants
@JeremyKuhne @Jessie-Zhang01 @vladimir-krestov