[Tracking] CsWin32 API Change/Add Requests

[lonitra]

In the effort to start using CsWin32 (#7445), there may be APIs we'd like changed or added in cswin32 due to missing typedefs, conveniency, etc. This is a tracking issue to help keep a list of these adds/changes we would like.

• CombineRgn method missing RegionType return type (Consider Changing CombineRgn Return Type to Enum microsoft/win32metadata#1024)
• RECT (Consider adding cast operators to System.Drawing types microsoft/CsWin32#626)
  • Implicit converter from RECT -> Rectangle
  • Width and Height properties for RECT
  • Convenient constructors e.g. RECT(int left, int top, int right, int bottom)
• SafeHandle usage prevents us from using convenience overloads (Ability to turn off usage of safe handles in overloads microsoft/CsWin32#605)
• Null value has to be explicitly cast to HINSTANCE (Null value for HINSTANCE microsoft/CsWin32#639)
• Enum type for GetROP2/SetROP2 Consider Adding Enum Type for GetROP2/SetROP2 microsoft/win32metadata#1045
• Enum type for GetTextAlign/SetTextAlign Consider Adding Enum Type for GetTextAlign/SetTextAlign microsoft/win32metadata#1036
• COLORREF return type for GetTextColor,GetBkColor Add COLORREF to CsWin32 microsoft/win32metadata#1035
• SHACF enum missing SHACF enum missing for shautocomplete microsoft/win32metadata#1027
• Enum for IME constants Add enums for IME Constants microsoft/win32metadata#1028
• Mapping for XFORM > Matrix3x2
• Enum type for LOGFONTW members/LF_FACESIZE Consider Updating LOGFONTW microsoft/win32metadata#1060
• UXTheme APIs don't have an HTHEME struct UXTheme APIs don't have an HTHEME struct microsoft/win32metadata#1273

Related:

• Epic - Improve Clipboard functionality #6269
• Broken custom IDataObject implementations #4555

[elachlan]

This would be helpful for SHAutoComplete method.
microsoft/win32metadata#1027

[elachlan]

This is blocking ImmGetConversionStatus:
microsoft/win32metadata#1028

[elachlan]

I am done! I have done my best to make sure I have covered everything, but I may have missed something.

We are going to have difficulties in ComCtl32 because lots of the enums defined in there are not defined in Win32Metadata and might not be added.

Ole32 has a lot of interface updates. But the conversion doesn't seem as bad.

The metadata team and winforms team will need to review and discuss the issues I have linked here.

CC: @sotteson1 and @mikebattista sorry for the issue spam.

[mikebattista]

Fortunately most of your issues are just with friendly enums which are easy to add.

[elachlan]

The biggest problem winforms will face is the messaging constants. Metadata doesn't group them into enums. Which makes it harder for winforms to consume them. There is a lot to be said for constants though. Since if you only use two of them, then you just import two of them via CsWin32. So the amount of generated code is less.

[merriemcgaw]

@JeremyKuhne is there anything pending from windows on this?

[JeremyKuhne]

There are still a few open issues, and we are probably missing a couple. We'll do another run through to ensure we have all of the open ones tracked.