-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drawing types templates #628
Conversation
CC: @lonitra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you added the functionality all right where it fits the design. Thank you. Just a couple of changes, please.
…enerated when allowMarshaling is set
The `SIZE` and and `RECT` structs have no BCL equivalents, at least not with the fields in the right order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that SIZE
cannot be replaced with the BCL Size
struct because the fields are in a different order. I moved POINT and POINTF to another dictionary in the generator so that they are never generated, even when not marshaling, since the BCL struct types should be adequate and this gives an even better interop experience. I deleted the point templates since we never generate those types any more.
Thank you for starting on this, for the tests and the rect and size templates. This is definitely an improvement.
Fixes #626
Related: dotnet/winforms#7468