Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] com2pictureconvertertests.convertmanagedtonative_icon #8634

Open
Tracked by #8607
runfoapp bot opened this issue Feb 13, 2023 · 2 comments
Open
Tracked by #8607

[Flaky Test] com2pictureconvertertests.convertmanagedtonative_icon #8634

runfoapp bot opened this issue Feb 13, 2023 · 2 comments
Labels
test-bug Problem in test source code (most likely)
Milestone

Comments

@runfoapp
Copy link

runfoapp bot commented Feb 13, 2023

Runfo Tracking Issue: [Flaky Test] com2pictureconvertertests.convertmanagedtonative_icon

Build Definition Kind Run Name

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 0
@dreddy-work
Copy link
Member

System.Runtime.InteropServices.COMException : Error HRESULT E_FAIL has been returned from a call to a COM component.


Stack trace
   at System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(Int32 errorCode, IntPtr errorInfo)
   at Windows.Win32.Foundation.HRESULT.ThrowOnFailure(IntPtr errorInfo) in /_/src/System.Windows.Forms.Primitives/src/Microsoft.Windows.CsWin32/Microsoft.Windows.CsWin32.SourceGenerator/Windows.Win32.HRESULT.g.cs:line 63
   at System.Windows.Forms.ComponentModel.Com2Interop.Com2PictureConverter.ConvertManagedToNative(Object managedValue, Com2PropertyDescriptor pd, Boolean& cancelSet) in /_/src/System.Windows.Forms/src/System/Windows/Forms/ComponentModel/COM2Interop/COM2PictureConverter.cs:line 120
   at System.Windows.Forms.Tests.ComponentModel.Com2Interop.COM2PictureConverterTests.ConvertManagedToNative_Icon() in /_/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComponentModel/Com2Interop/COM2PictureConverterTests.cs:line 120
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

@JeremyKuhne
Copy link
Member

Sharing an instance probably isn't a great idea as there is cached state:

private static Com2PictureConverter Instance { get; } = new Com2PictureConverter(new Com2PropertyDescriptor(

Presumably the PICTDESC creation failed- we should add some assertions there to check the state to get this narrowed down.

@ghost ghost added 🚧 work in progress Work that is current in progress and removed 🚧 work in progress Work that is current in progress labels Mar 14, 2023
@elachlan elachlan added the test-bug Problem in test source code (most likely) label Nov 3, 2023
@JeremyKuhne JeremyKuhne added this to the Future milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants