When the cursor is not over any control and not in a row/column, chan… #10230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge insertIndex to the last one.
ghost
assigned 
|
@LeafShi1 LGTM! |
Tanya-Solyanik
approved these changes
Nov 7, 2023
LeafShi1
deleted the
Fixing_FlowLayoutPanel_OnDragOver_UpdateInsertionIndex
branch
|
Verified this PR on latest main 9.0 branch of winforms repo, the top control can be moved to the bottom now. 10230-2.mp4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting fix from the Out-Of-Process designer
Proposed changes
When the cursor is not over any control and not in a row/column, change insertIndex to the last one.
Root cause of this bug
In the original code, when the cursor is not on any control and not in a row/column, only the IBar is erased without processing the InsertionIndex of the control, so the top control cannot move to the bottom.
Before
The top control cannot be moved to the bottom, it always backs to the original position.
After
The top control can be moved to the bottom
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow