Initial implementation of GDI+ effects #10750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes most of the GDI+ effects under the [RequiresPreviewFeatures] while we take it to .NET API review. Effects are added under the `Imaging\Effects` namespace. The new effects are: - BlackSaturation - Blur - BrightnessContrast - ColorBalance - ColorLookupTable - ColorMatrix - Contrast - Density - Exposure - Highlight - Levels - Midtone - Shadow - Sharpen - Tint - WhiteSaturation This also adds: - New, efficient constructor to ColorMatrix that takes a span of floats - Overload for Graphics.DrawImage that allows you to draw with an effect (and fix the perf of the indexer) - An ApplyEffect method on Bitmap that lets you apply an effect to an existing bitmap - Adds the uses preview features flag to the scratch projects Effects are applied to bitmaps, not associated with them. The image doesn't retain a handle, it just modifies the bits using the effect. As such I have not exposed a way to mutate the effect classes after creation. The cost of creating an effects class is not high, but they should be disposed to avoid having them clutter the finalizer queue. I also did not include the red eye removal effect as it is sort of a one-off from general image effects. GDI+ won't be adding any new effects (these were added over 20 years ago). Tests are pending.
ghost
assigned 
|
Related to #8835 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10750 +/- ##
===================================================
- Coverage 72.66649% 72.65214% -0.01435%
===================================================
Files 2903 2925 +22
Lines 622024 622685 +661
Branches 46863 46918 +55
===================================================
+ Hits 452003 452394 +391
- Misses 161715 161952 +237
- Partials 8306 8339 +33
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@KlausLoeffelmann #8835 has the API proposal and we don't have api.txt files for System.Drawing. We build for multiple frameworks so I'm not even sure it is possible; I'll look into it when I get a chance. |
lonitra
reviewed
Jan 29, 2024
src/System.Windows.Forms/tests/IntegrationTests/ScratchProject/ScratchProject.csproj
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes most of the GDI+ effects under the [RequiresPreviewFeatures] while we take it to .NET API review.
Effects are added under the
Imaging\Effectsnamespace. The new effects are:This also adds:
Effects are applied to bitmaps, not associated with them. The image doesn't retain a handle, it just modifies the bits using the effect. As such I have not exposed a way to mutate the effect classes after creation. The cost of creating an effects class is not high, but they should be disposed to avoid having them clutter the finalizer queue.
I also did not include the red eye removal effect as it is sort of a one-off from general image effects. GDI+ won't be adding any new effects (these were added over 20 years ago).
Tests are pending.
Microsoft Reviewers: Open in CodeFlow