Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for MonthCalendar #11217

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Apr 15, 2024

related #10453

Proposed changes

  • Add unit tests for MonthCalendar to test its properties: HitTestInfo, HitArea, Help, Name, Bounds, Description, Role , State
  • Add unit tests for MonthCalendar to test its methods: GetFocused(), Select().

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 94.40559% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 74.34049%. Comparing base (0eb3e7b) to head (f59bc48).
Report is 36 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11217         +/-   ##
===================================================
+ Coverage   73.47521%   74.34049%   +0.86527%     
===================================================
  Files           3101        3012         -89     
  Lines         632431      625885       -6546     
  Branches       46688       46553        -135     
===================================================
+ Hits          464680      465286        +606     
+ Misses        164343      157204       -7139     
+ Partials        3408        3395         -13     
Flag Coverage Δ
Debug 74.34049% <94.40559%> (+0.86527%) ⬆️
integration 18.33496% <ø> (-0.02961%) ⬇️
production 46.98336% <ø> (+0.01556%) ⬆️
test 97.04028% <94.40559%> (+2.05223%) ⬆️
unit 43.92762% <ø> (-0.00976%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Apr 15, 2024
@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Apr 17, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Apr 18, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Apr 18, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Apr 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Apr 23, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Apr 23, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit 921c2b4 into dotnet:main Apr 23, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview5 milestone Apr 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Apr 23, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_MonthCalendar branch April 24, 2024 01:09
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants