Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unstable test "ToolTip_SetToolTip_TabControl_DoesNotAddToolForTabControlItself" and "ToolTip_WmShow_Invokes_AnnounceText_WithExpectedText_ForTabControlTabs" #11235

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Apr 18, 2024

Related #11234#11236

Proposed changes

  • Add label SkipOnArchitecture for unstable test ToolTip_SetToolTip_TabControl_DoesNotAddToolForTabControlItself
  • Comment out mockAccessibleObject.Verify of the unstable test ToolTip_WmShow_Invokes_AnnounceText_WithExpectedText_ForTabControlTabs

Risk

  • Low
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner April 18, 2024 08:33
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@b0be660). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11235   +/-   ##
==========================================
  Coverage        ?   74.33913%           
==========================================
  Files           ?        3009           
  Lines           ?      624971           
  Branches        ?       46494           
==========================================
  Hits            ?      464598           
  Misses          ?      156980           
  Partials        ?        3393           
Flag Coverage Δ
Debug 74.33913% <ø> (?)
integration 18.36562% <ø> (?)
production 46.94980% <ø> (?)
test 97.05308% <ø> (?)
unit 43.88267% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@LeafShi1 LeafShi1 changed the title Add skip label for unstable test "ToolTip_SetToolTip_TabControl_DoesNotAddToolForTabControlItself" Skip unstable test "ToolTip_SetToolTip_TabControl_DoesNotAddToolForTabControlItself" and "ToolTip_WmShow_Invokes_AnnounceText_WithExpectedText_ForTabControlTabs" Apr 18, 2024
@LeafShi1 LeafShi1 merged commit a172156 into dotnet:main Apr 19, 2024
8 checks passed
@LeafShi1 LeafShi1 deleted the Issue_111234_SkipTest_ToolTip_SetToolTip_TabControl_DoesNotAddToolForTabControlItself branch April 19, 2024 02:09
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview4 milestone Apr 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants