Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for DateTimePicker 12 properties #11385

Merged

Conversation

John-Qiao
Copy link
Member

@John-Qiao John-Qiao commented May 16, 2024

related #10453

Proposed changes

  • Add unit tests for below 12 properties
  1. CalendarFont
  2. Checked
  3. CustomFormat
  4. DropDownAlign
  5. MaxDate
  6. MaximumDateTime
  7. MinDate
  8. MinimumDateTime
  9. RightToLeftLayout
  10. ShowUpDown
  11. Text
  12. Value
Microsoft Reviewers: Open in CodeFlow

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 98.01980% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.36375%. Comparing base (27d748e) to head (7b66ecc).
Report is 51 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11385         +/-   ##
===================================================
+ Coverage   74.27404%   74.36375%   +0.08970%     
===================================================
  Files           3025        3028          +3     
  Lines         626857      627506        +649     
  Branches       46741       46772         +31     
===================================================
+ Hits          465592      466637       +1045     
+ Misses        157914      157522        -392     
+ Partials        3351        3347          -4     
Flag Coverage Δ
Debug 74.36375% <98.01980%> (+0.08970%) ⬆️
integration 17.99721% <ø> (-0.00295%) ⬇️
production 47.15960% <ø> (+0.16492%) ⬆️
test 96.98686% <98.01980%> (-0.01400%) ⬇️
unit 44.13756% <ø> (+0.16821%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 27, 2024
@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label May 28, 2024
@LeafShi1
Copy link
Member

LGTM! @lonitra Please review this PR

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments, otherwise LGTM!

@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 29, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 30, 2024
@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label May 30, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit db426a2 into dotnet:main May 30, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview6 milestone May 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants