Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for combobox #11565

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

Nora-Zhou01
Copy link
Member

@Nora-Zhou01 Nora-Zhou01 commented Jun 20, 2024

Related #10453

Proposed changes

  • Add unit tests for ComboBox to test its methods: GetItemHeight, ResetText, SelectAll
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.48360%. Comparing base (566bec4) to head (7cece47).
Report is 20 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11565         +/-   ##
===================================================
- Coverage   74.48439%   74.48360%   -0.00080%     
===================================================
  Files           3039        3039                 
  Lines         629066      629121         +55     
  Branches       46834       46836          +2     
===================================================
+ Hits          468556      468592         +36     
- Misses        157154      157179         +25     
+ Partials        3356        3350          -6     
Flag Coverage Δ
Debug 74.48360% <100.00000%> (-0.00080%) ⬇️
integration 17.98018% <ø> (+0.00168%) ⬆️
production 47.36260% <ø> (+0.01429%) ⬆️
test 96.95292% <100.00000%> (-0.01832%) ⬇️
unit 44.32283% <ø> (-0.01528%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jun 20, 2024
@ricardobossan ricardobossan added the 📭 waiting-author-feedback The team requires more information from the author label Jun 20, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jun 21, 2024
@LeafShi1
Copy link
Member

@lonitra Please help review this PR

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lonitra lonitra merged commit 2969303 into dotnet:main Jun 27, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview7 milestone Jun 27, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Jun 27, 2024
@Nora-Zhou01 Nora-Zhou01 deleted the Add-code-coverage-for-ComboBox branch July 3, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants