Update contributing-guide.md #129
Conversation
Documentation/contributing-guide.md
Outdated
| For instructions on how test your changes before submitting a pull request, please see our [Testing](https://github.com/dotnet/winforms/blob/master/Documentation/testing.md) document. It contains directions on how to run our tests as well as guidelines for writing new ones. | ||
| To work in this repository, begin by observing the following: | ||
| 1. Clone this repository | ||
| * Fork your own copy of the [WinForms repository]( https://github.com/dotnet/winforms) with the _Fork_ button on the repository’s web page to your account. |
There was a problem hiding this comment.
Just curious, why you (in previous change) removed this link? https://github.com/dotnet/corefx/wiki/Checking-out-the-code-repository ... it was actually contributed by CoreFX contributors and has IMO nice intro into git fork/clone/setup.
(not blocking)
There was a problem hiding this comment.
I just thought it was a little verbose for what we're looking for. Maybe even this is. I used to teach a lot of university kids how to use git and github for the first time, so I'm in that mindset with step 1.
that said, I guess I could anchor link
Co-Authored-By: zsd4yr <zsd4yr@users.noreply.github.com>
|
Do not merge. I plan to merge this tonight to test merge permissions in this repo. |
|
LOL I think Zach did it right when you were adding that comment :) |
|
Lmao yeah race conditions |
|
@shanselman maybe the best thing to do would be to make an exact copy of master as it stands in another branch and try to merge the PR you plan on using in that just to make sure the merge process runs as expected against master? Not sure what other vetting has been done |
No description provided.