Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to ignore vscode #150

Merged
merged 1 commit into from Dec 5, 2018
Merged

Conversation

zsd4yr
Copy link
Member

@zsd4yr zsd4yr commented Dec 4, 2018

No description provided.

@zsd4yr zsd4yr requested a review from a team as a code owner December 4, 2018 21:28
@zsd4yr zsd4yr self-assigned this Dec 4, 2018
Copy link
Member

@richlander richlander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert of the specific syntax used, but I like the idea.

!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why the 'not' lines? Looks like CoreFX does not have it: https://github.com/dotnet/corefx/blob/master/.gitignore#L274-L275

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might exclude these to control certain aspects of vscode repo-wide; We probably don't need to exclude these; I was just following the wisdom of the blob

@AdamYoblick AdamYoblick merged commit 2049ee8 into master Dec 5, 2018
@AdamYoblick AdamYoblick deleted the dev/zadanz/vscode-ignore branch December 5, 2018 19:05
@dotnet dotnet locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants