Use ValueTuple instead of Tuple for internal cache

[sharwell]

No description provided.

[sharwell]

📝 Not considering the new use of ValueTuple, The only difference between this file and the one that's used is the placement of these using directives.

[zsd4yr]

@sharwell which Issue does this address?

[zsd4yr]

Would you mind also writing some unit tests for IsApiAvailable against expected and erroneous values? I believe CommonUnsafeNativeMethods should have some values which are expected to work

[sharwell]

@sharwell which Issue does this address?

No specific issue. I observed this by accident while investigating something else.

Would you mind also writing some unit tests for IsApiAvailable against expected and erroneous values?

I can try to get these but it may take me a bit to complete the update.

[sharwell]

@zsd4yr Added tests

[zsd4yr]

@sharwell which Issue does this address?

No specific issue. I observed this by accident while investigating something else.

@sharwell would you mind making one? Simply to track this work independent of the PR

[sharwell]

would you mind making one? Simply to track this work independent of the PR

For most of the projects I maintain, I apply labels to the pull request itself if and only if it doesn't strictly resolve one or more existing issues. On GitHub, pull requests are treated roughly equivalent to issues for search/triage/reference purposes, so you can apply labels to it to treat it as both a pull request and an issue. An issue could be created, but it would really just be noise and a new level of indirection.

[karelz]

@sharwell what is the reason for no squash? Do you want to preserve history of different changes which is valuable in this specific case? Or is it something you believe is right all the time?

I agree we don't need a new issue in this case. It would not bring additional value.
In general, PRs are poor place for discussions - we ask to open new issues when a PR adds new API (it needs API review), or when the solution needs larger design discussion, or discussion if it is worth fixing at all.

BTW: We do not place labels on PRs - see PR guidence.

[zsd4yr]

^ the guidance has changed. I will label the pr appropriate to the request not to squash.

[sharwell]

I'm rebasing this the following commits:

1. Shared ApiHelper.cs and add tests
2. Update ApiHelper to use (string, string) instead of Tuple<string, string>

I'll push the second commit after I see the first one pass CI.