Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Gdi32 Pen/Brush interop #1928

Merged
merged 1 commit into from Sep 19, 2019
Merged

Cleanup Gdi32 Pen/Brush interop #1928

merged 1 commit into from Sep 19, 2019

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Sep 17, 2019 •
edited by ghost

Proposed Changes

  • Cleanup LOGBRUSH related code
  • Cleanup Brush related code
  • Cleanup Pen related code
Microsoft Reviewers: Open in CodeFlow

@hughbe hughbe requested a review from a team as a code owner September 17, 2019 22:25
@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited

Codecov Report

Merging #1928 into master will increase coverage by 0.37622%.
The diff coverage is 34.95145%.

@@                 Coverage Diff                 @@
##              master       #1928         +/-   ##
===================================================
+ Coverage   26.79595%   27.17217%   +0.37622%     
===================================================
  Files            855         857          +2     
  Lines         266794      266784         -10     
  Branches       37916       37916                 
===================================================
+ Hits           71490       72491       +1001     
+ Misses        190200      189104       -1096     
- Partials        5104        5189         +85
Flag Coverage Δ
#Debug 27.17217% <34.95145%> (+0.37622%) ⬆️
#production 27.17217% <34.95145%> (+0.37622%) ⬆️
#test 100% <ø> (ø) ⬆️

RussKie
RussKie previously approved these changes Sep 18, 2019
View reviewed changes
@RussKie RussKie added code cleanup cleanup code for unused apis/properties/comments - no functional changes. enhancement Product code improvement that does NOT require public API changes/additions labels Sep 19, 2019
@RussKie RussKie merged commit 7f6353a into dotnet:master Sep 19, 2019
@ghost ghost added this to the 5.0 milestone Sep 19, 2019
@hughbe hughbe deleted the brush-pen-gdi32 branch September 19, 2019 17:33
@dotnet dotnet locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zsd4yr zsd4yr zsd4yr left review comments

@RussKie RussKie RussKie approved these changes

Assignees

@hughbe hughbe

Labels
code cleanup cleanup code for unused apis/properties/comments - no functional changes. enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
5.0 Previews 1-4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hughbe @RussKie @zsd4yr