Add Missing Types to Intrinsic TypeDescriptor table #1936
Conversation
| TypeDescriptor.AddEditorTable(typeof(UITypeEditor), UITypeEditor.s_intrinsicEditors); | ||
|
|
||
| IList list = new List<int>(); | ||
| var editor = TypeDescriptor.GetEditor(typeof(IList), typeof(UITypeEditor)); |
There was a problem hiding this comment.
Does this work for other types, for example for non-interface types?
Does this work for the instance TypeDescriptor.GetEditor(list...)
There was a problem hiding this comment.
Yes these cases should be added to the tests, most callers won't ask for the editor on the interface type but either pass a concrete class type or an actual instance implementing the interface.
|
#1115 contains the list of missing editors |
|
Looks like editor table can be added only once - https://github.com/dotnet/corefx/blob/3cc18081e24acdcfe7db737400a2dc702e314395/src/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs#L159-L181 And the first time we search for the editor, and not find it, we place a sentinel into the table to not search again. https://github.com/dotnet/corefx/blob/3cc18081e24acdcfe7db737400a2dc702e314395/src/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs#L328-L369 |
I wonder if in my tests it had been added to already? |
ghost
added
the
There is an issue in the design repo where certain types did not have the EditorAttribute on them as they did in .NET FX. This is intentional as many of these types were moved down to CoreFX and are fascaded, example: System.Drawing.Image @KlausLoeffelmann first reported this and @DustinCampbell expanded this to include other types.
upon further inspection, a great many types are missing.
Microsoft Reviewers: Open in CodeFlow