New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove most usages of WIndowsGraphicsWrapper #3532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor DpiHelper a bit, adding new API to avoid DC creation (using new GetDpiForSystem()) - Add PaintEvent HDC wrapper to favor getting the natvie HDC if the Graphics wrapper hasn't been created - Extend DeviceContextHdcScope to support WindowsGraphicsWrapper migration - Change HDC property on PaintEventArgs - Add DrawLine to HDC extensions (from WindowsGraphics) - Graphics.DpiX is no different than normal device DPI, removed from CheckableControlBaseAdapter.cs - Remove Graphics from CheckBoxPopupAdapter.PaintPopupLayout - Add SetBkMode scope Remove WindowsGraphics/Wrapper from a number of methods.
ghost
assigned JeremyKuhne
Jul 2, 2020
A lot of tests failing
|
weltkante
reviewed
Jul 2, 2020
src/System.Windows.Forms/src/System/Windows/Forms/ButtonInternal/CheckableControlBaseAdapter.cs
Show resolved
Hide resolved
Remove lazy initialization of the scope and make it readonly so cast operators don't copy the struct
Fix line split in DrawThemeBackground
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #3532 +/- ##
====================================================
- Coverage 67.03175% 35.58549% -31.44627%
====================================================
Files 1352 900 -452
Lines 505814 252943 -252871
Branches 40899 36729 -4170
====================================================
- Hits 339056 90011 -249045
+ Misses 161191 158080 -3111
+ Partials 5567 4852 -715
|
RussKie
approved these changes
Jul 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove WindowsGraphics/Wrapper from a number of methods.
Microsoft Reviewers: Open in CodeFlow