Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead ctor checks in ListItemConverter #367

Merged
merged 2 commits into from Feb 11, 2019
Merged

Remove dead ctor checks in ListItemConverter #367

merged 2 commits into from Feb 11, 2019

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Jan 24, 2019 •
edited

ctor is never null when getting the instancedescriptor

the other changes are formatting cleanups

@hughbe hughbe requested a review from a team as a code owner January 24, 2019 20:04
@zsd4yr
Copy link
Member

zsd4yr commented Jan 30, 2019

@hughbe would you mind making the formatting changes as a second commit so that we can easily review the functional change?

@hughbe
Copy link
Contributor Author

hughbe commented Feb 1, 2019

Sure! updated

zsd4yr
zsd4yr approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@zsd4yr zsd4yr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@zsd4yr zsd4yr merged commit 7b538a6 into dotnet:master Feb 11, 2019
@hughbe hughbe deleted the converter-dc branch February 11, 2019 18:20
@dotnet dotnet locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zsd4yr zsd4yr zsd4yr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hughbe @zsd4yr