Fixes #3663 #3679
Merged
Fixes #3663 #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
approved these changes
Jul 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #3679 +/- ##
====================================================
- Coverage 67.14224% 35.70256% -31.43969%
====================================================
Files 1380 909 -471
Lines 503181 249758 -253423
Branches 40771 36559 -4212
====================================================
- Hits 337847 89170 -248677
+ Misses 159609 155586 -4023
+ Partials 5725 5002 -723
Flags with carried forward coverage won't be shown. Click here to find out more. |
Olina-Zhang
reviewed
Jul 31, 2020
| @@ -388,12 +388,13 @@ private void InitializeComponent() | |||
| // | |||
| // toolStripComboBox1 | |||
| // | |||
| this.toolStripComboBox1.AccessibleName = "Custom accessible name for combo box"; | |||
There was a problem hiding this comment.
This custom accessible name is not proper, it is also failed.
| @@ -583,7 +584,7 @@ private void InitializeComponent() | |||
| // | |||
| // toolStripProgressBar1 | |||
| // | |||
| this.toolStripProgressBar1.AccessibleName = "Proressbar"; | |||
| this.toolStripProgressBar1.AccessibleName = "Custom accessible name for progress bar"; | |||
There was a problem hiding this comment.
The result of progressBar is same as comboBox:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added accessible name property to ToolStrip combo box in the test app
Fixes #3663
Microsoft Reviewers: Open in CodeFlow