Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AccessibleObject native tests #3732

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Add AccessibleObject native tests #3732

merged 3 commits into from
Oct 13, 2020

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Aug 14, 2020 •
edited by ghost
Loading

Proposed Changes

  • Add AccessibleObject native tests
Microsoft Reviewers: Open in CodeFlow

@hughbe hughbe requested a review from a team as a code owner August 14, 2020 13:02
@ghost ghost assigned hughbe Aug 14, 2020
@hughbe hughbe force-pushed the AccessibleObjectNativeTests branch from 9d3a7ea to 7a6fd6e Compare August 15, 2020 10:10
@RussKie
Copy link
Member

RussKie commented Aug 17, 2020

Something is still amiss...

    System.Windows.Forms.InteropTests.AccesibleObjectTests.AccesibleObject_IAccessibleExGetObjectForChild_Invoke_ReturnsExpected(idChild: -2) [FAIL]
      System.EntryPointNotFoundException : Unable to find an entry point named 'Test_IAccessibleExGetObjectForChild' in DLL 'NativeTests'.
      Stack Trace:
           at System.Windows.Forms.InteropTests.AccesibleObjectTests.Test_IAccessibleExGetObjectForChild(Object pUnk, Int64 idChild)
        F:\workspace\_work\1\s\src\System.Windows.Forms\tests\InteropTests\AccessibleObjectTests.cs(45,0): at System.Windows.Forms.InteropTests.AccesibleObjectTests.AccesibleObject_IAccessibleExGetObjectForChild_Invoke_ReturnsExpected(Int64 idChild)

@RussKie RussKie added area-Interop tenet-accessibility MAS violation, UIA issue; problems with accessibility standards test-enhancement Improvements of test source code 📭 waiting-author-feedback The team requires more information from the author and removed area-Interop tenet-accessibility MAS violation, UIA issue; problems with accessibility standards test-enhancement Improvements of test source code labels Aug 17, 2020
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 25, 2020 •
edited
Loading

Codecov Report

Merging #3732 into master will increase coverage by 30.02298%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##              master       #3732          +/-   ##
====================================================
+ Coverage   68.12191%   98.14489%   +30.02298%     
====================================================
  Files           1478         494         -984     
  Lines         508782      258367      -250415     
  Branches       41437        4476       -36961     
====================================================
- Hits          346592      253574       -93018     
+ Misses        155958        4035      -151923     
+ Partials        6232         758        -5474
Flag Coverage Δ
#Debug 98.14489% <ø> (+30.02298%) ⬆️
#production ?
#test 98.14489% <ø> (+0.00773%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hughbe
Copy link
Contributor Author

hughbe commented Sep 25, 2020

Great looks like we have this working. In terms of the entrypoint failures it was some places where I had long instead of int in the c# PInvoke definition. For some reason this worked locally and in .NET Framework but not on the CI

RussKie
RussKie reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

src/System.Windows.Forms/src/System/Windows/Forms/AccessibleObject.cs Outdated Show resolved Hide resolved
@RussKie RussKie added the 📭 waiting-author-feedback The team requires more information from the author label Sep 28, 2020
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 6, 2020
@RussKie RussKie added the 📭 waiting-author-feedback The team requires more information from the author label Oct 8, 2020
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 12, 2020
@hughbe hughbe force-pushed the AccessibleObjectNativeTests branch from 87127f9 to d4fd810 Compare October 12, 2020 11:30
@RussKie RussKie merged commit 3636e2b into dotnet:master Oct 13, 2020
@ghost ghost added this to the 6.0 Preview1 milestone Oct 13, 2020
@RussKie
Copy link
Member

RussKie commented Oct 13, 2020

Thank you!

@hughbe hughbe deleted the AccessibleObjectNativeTests branch October 13, 2020 09:48
@ghost ghost locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie left review comments

@vladimir-krestov vladimir-krestov vladimir-krestov left review comments

Assignees

@hughbe hughbe

Labels
area-Interop tenet-accessibility MAS violation, UIA issue; problems with accessibility standards test-enhancement Improvements of test source code
Projects
None yet
Milestone
6.0 Preview1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hughbe @RussKie @vladimir-krestov