Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Text pattern to PropertyGridView.GridViewEdit #3876

Merged
merged 1 commit into from Sep 21, 2020
Merged

Adding Text pattern to PropertyGridView.GridViewEdit #3876

merged 1 commit into from Sep 21, 2020

Conversation

vladimir-krestov
Copy link
Contributor

@vladimir-krestov vladimir-krestov commented Sep 10, 2020 •
edited by ghost

Fixes #3683
Original Bug: 1159883
Based on PR #2701

Proposed changes

  • Enable Text pattern support for GridViewEditAccessibleObject

Customer Impact

  • Visually impaired users will be able to read and interact with the text content of a ToolStripTextBox

Regression?

  • No

Risk

  • Minimal

Before

  • Narrator does not announce the text navigation and selection of a PropertyGridView.GridViewEdit

After

  • Narrator announces the text content of a PropertyGridView.GridViewEdit (navigation, selection)

Test methodology

  • Manual testing
  • CTI
  • Unit tests

Accessibility testing

  • Using Narrator and Inspect

Test environment(s)

  • Net 5.0 Version: 5.0.0-rc.1.20431.5
  • Microsoft Windows [Version 10.0.19041.450]
Microsoft Reviewers: Open in CodeFlow

@vladimir-krestov vladimir-krestov requested a review from a team as a code owner September 10, 2020 17:45
@vladimir-krestov vladimir-krestov force-pushed the Issue_3683_AddingTextPatter_to_PropertyGridEdit branch 2 times, most recently from 13b8dc2 to 6a77630 Compare September 10, 2020 18:03
@vladimir-krestov vladimir-krestov added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020 •
edited

Codecov Report

Merging #3876 into release/5.0-rc2 will decrease coverage by 31.12761%.
The diff coverage is 50.00000%.

@@                    Coverage Diff                     @@
##           release/5.0-rc2       #3876          +/-   ##
==========================================================
- Coverage         67.61003%   36.48242%   -31.12761%     
==========================================================
  Files                 1408         921         -487     
  Lines               507123      250962      -256161     
  Branches             41178       36858        -4320     
==========================================================
- Hits                342866       91557      -251309     
+ Misses              158286      154165        -4121     
+ Partials              5971        5240         -731
Flag Coverage Δ
#Debug 36.48242% <50.00000%> (-31.12761%) ⬇️
#production 36.48242% <50.00000%> (+0.00231%) ⬆️
#test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@vladimir-krestov vladimir-krestov added this to the 5.0 RC2 milestone Sep 10, 2020
@vladimir-krestov
Copy link
Contributor Author

vladimir-krestov commented Sep 11, 2020 •
edited

Testers approved the fix ✔️
There are 2 known issues that will be fixed as a separate fix for DataGridViewTextBoxCell and ToolStripTextBox too:

But the main Issue #3683 was fixed

@vladimir-krestov vladimir-krestov added waiting-review This item is waiting on review by one or more members of team and removed 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) labels Sep 11, 2020
RussKie
RussKie requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebased

@ghost ghost added the 📭 waiting-author-feedback The team requires more information from the author label Sep 14, 2020
@vladimir-krestov vladimir-krestov force-pushed the Issue_3683_AddingTextPatter_to_PropertyGridEdit branch from 9e8d6f6 to 35950de Compare September 14, 2020 06:36
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 14, 2020
RussKie
RussKie requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM module the feedback

...ows/Forms/PropertyGridInternal/PropertyGridView.GridViewEdit.GridViewEditAccessibleObject.cs Show resolved Hide resolved
@ghost ghost added the 📭 waiting-author-feedback The team requires more information from the author label Sep 14, 2020
@RussKie RussKie removed the waiting-review This item is waiting on review by one or more members of team label Sep 14, 2020
@vladimir-krestov vladimir-krestov force-pushed the Issue_3683_AddingTextPatter_to_PropertyGridEdit branch from 35950de to 46d2863 Compare September 14, 2020 19:47
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 14, 2020
@vladimir-krestov vladimir-krestov added the waiting-review This item is waiting on review by one or more members of team label Sep 15, 2020
@RussKie RussKie added Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria and removed waiting-review This item is waiting on review by one or more members of team labels Sep 17, 2020
@RussKie RussKie linked an issue Sep 17, 2020 that may be closed by this pull request
[Accessibility] An element of the given ControlType must support the Text pattern for PropertyGrid: Text tree items #3683
Closed
@RussKie RussKie added Servicing-approved .NET Shiproom approved the PR for merge and removed Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels Sep 21, 2020
@RussKie
Copy link
Member

RussKie commented Sep 21, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@RussKie RussKie merged commit 7954ed7 into dotnet:release/5.0-rc2 Sep 21, 2020
@vladimir-krestov vladimir-krestov deleted the Issue_3683_AddingTextPatter_to_PropertyGridEdit branch November 4, 2020 07:36
@dotnet dotnet locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie approved these changes

Assignees

@vladimir-krestov vladimir-krestov

Labels
Servicing-approved .NET Shiproom approved the PR for merge
Projects
None yet
Milestone
5.0 RC2
2 participants
@vladimir-krestov @RussKie