Adding access to page buttons on PrintPreviewDialog by keyboard shortcut keys #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeySmirnov-Akvelon
added
the
waiting-review
Codecov Report
@@ Coverage Diff @@
## master #3929 +/- ##
====================================================
- Coverage 67.59941% 36.44908% -31.15034%
====================================================
Files 1415 933 -482
Lines 505784 250363 -255421
Branches 41079 36785 -4294
====================================================
- Hits 341907 91255 -250652
+ Misses 157924 153876 -4048
+ Partials 5953 5232 -721
Flags with carried forward coverage won't be shown. Click here to find out more. |
| </data> | ||
| <data name="sixpagesToolStripButton.Text"> | ||
| <value xml:space="preserve">Six pages</value> | ||
| <value xml:space="preserve">Six pages (Ctrl+5)</value> |
There was a problem hiding this comment.
What was the reason to go with Ctrl+5 and not with Ctrl+6? Did you find any guidance about it?
There was a problem hiding this comment.
This was my suggestion #3682 (comment) that everyone has agreed with.
In my opinion it is a logical sequence - option 1, 2, ...5, and not based on number of pages. E.g. if there was a sixth option to show 12 pages - as a user I wouldn't expect CTRL+12 but CTRL+6.
There was a problem hiding this comment.
Had you guys looked at what Office or windows are doing in similar cases?
RussKie
reviewed
Sep 17, 2020
src/System.Windows.Forms/src/System/Windows/Forms/Printing/PrintPreviewDialog.cs
Outdated
Show resolved
Hide resolved
RussKie
added
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
RussKie
previously approved these changes
Sep 17, 2020
SergeySmirnov-Akvelon
force-pushed
the
Issue-3682_Keyboard_shortcut_key_is_unavailable_to_access_the_buttons
branch
from
a589c8f
to
08a78c7
Compare
RussKie
requested changes
Sep 18, 2020
ghost
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
RussKie
approved these changes
Sep 25, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RussKie
deleted the
Issue-3682_Keyboard_shortcut_key_is_unavailable_to_access_the_buttons
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3682
Proposed changes
Customer Impact
Regression?
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow