Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to reduce concurrency while accessing ImageList #4113

Merged
merged 1 commit into from Oct 15, 2020

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Oct 15, 2020

ImageList appears to behave badly under stress and in heavy multy-threaded environments, e.g. #3898 (comment).
A shot from a hip in attempt to reduce concurrency.

Relates to #3898

Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie requested a review from a team as a code owner October 15, 2020 07:49
@ghost ghost assigned RussKie Oct 15, 2020
@RussKie RussKie added the test-bug Problem in test source code (most likely) label Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #4113 into master will increase coverage by 30.02909%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##              master       #4113          +/-   ##
====================================================
+ Coverage   68.11538%   98.14447%   +30.02908%     
====================================================
  Files           1482         494         -988     
  Lines         508772      258309      -250463     
  Branches       41453        4479       -36974     
====================================================
- Hits          346552      253516       -93036     
+ Misses        155988        4035      -151953     
+ Partials        6232         758        -5474     
Flag Coverage Δ
#Debug 98.14447% <ø> (+30.02908%) ⬆️
#production ?
#test 98.14447% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RussKie RussKie merged commit ff5496d into dotnet:master Oct 15, 2020
@ghost ghost added this to the 6.0 Preview1 milestone Oct 15, 2020
@RussKie RussKie deleted the fix_3898_take2 branch October 15, 2020 21:06
@dotnet dotnet locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant