Adding border for focused ToolStripButton in PropertyGrid #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ween focused and checked status dotnet#4268 Added a special method for high contrast mode that draws a black and white dashed border
SergeySmirnov-Akvelon
force-pushed
the
Issue-4268_ToolStripButtons_in_PropertyGrid_should_have_obvious_distinct_between_focused_and_checked_status
branch
from
0e3d5e1
to
6ffd171
Compare
Codecov Report
@@ Coverage Diff @@
## master #4282 +/- ##
=============================================
Coverage 97.96185% 97.96185%
=============================================
Files 499 499
Lines 259010 259010
Branches 4569 4569
=============================================
Hits 253731 253731
Misses 4473 4473
Partials 806 806
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
That looks reasonable to me. |
|
Have you tested with visual styles off? |
RussKie
added
the
📭 waiting-author-feedback
|
This is how it looks in normal mode when styles are disabled: For high contrast mode, I saw no difference with styles on and off. |
ghost
removed
the
📭 waiting-author-feedback
RussKie
approved these changes
Nov 26, 2020
RussKie
deleted the
Issue-4268_ToolStripButtons_in_PropertyGrid_should_have_obvious_distinct_between_focused_and_checked_status
branch
| leftColor: Color.Black, leftWidth: 1, leftStyle: ButtonBorderStyle.Dashed, // left | ||
| topColor: Color.Black, topWidth: 1, topStyle: ButtonBorderStyle.Dashed, // top | ||
| rightColor: Color.Black, rightWidth: 1, rightStyle: ButtonBorderStyle.Dashed, // right | ||
| bottomColor: Color.Black, bottomWidth: 1, bottomStyle: ButtonBorderStyle.Dashed); // bottom;*/ |
There was a problem hiding this comment.
what is the closing comment char doing in the end of this line?
There was a problem hiding this comment.
This is a typo, I will fix it in #4193
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4268
Proposed changes
Customer Impact
Before fix:
After fix:
Normal mode:
High Contrast 1:
High Contrast 2:
High Contrast Black:
High Contrast White:
Regression?
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow