Add a new virtual property StatusStripBorder to ToolStripProfessional…

[Balkoth]

Resolves #4643

Summary

Currently, if you want to theme your application with a ToolStripProfessionalRenderer, there is an issue with the StatusStrip border, as the drawing routine uses a hardcoded value for the border color. A new virtual property is added to the ProfessionalColorTable to customize that color.

[dnfadmin]

All CLA requirements met.

[RussKie]

👀

[RussKie]

We also need to see whether we can add a rendering test to assert correct colours are applied (e.g. something similar to ToolStrip_RendersBackgroundCorrectly).

[RussKie]

You can grab it here https://visualstudio.microsoft.com/vs/preview/ 😉

[Balkoth]

Is there an updated developer guide, what i have to have installed on my system in order to build this. The one here https://github.com/dotnet/winforms/blob/main/docs/developer-guide.md is outdated.

If i have to install all this preview stuff, i don't know if i can complete this. My machine is a production machine and i do not want to mess it up like this. What was once a simple change escalates way beyond my initial intent. Maybe someone at Microsoft with a working dev environment might pick this up...

[RussKie]

The one here https://github.com/dotnet/winforms/blob/main/docs/developer-guide.md is outdated.

What are you finding in the guide that appears outdated?

[Balkoth]

Windows Forms requires the following workloads and components be selected when installing Visual Studio 2019 (16.8+):

Required Workloads:

.NET Desktop Development
Desktop development with C++

This does not match what you really need in order to build the project.

[RussKie]

This does not match what you really need in order to build the project.

What isn't matching, and what's missing?

[Balkoth]

You need preview versions of .NET an Visual Studio. I don't know what the exact versions are.

[RussKie]

.NET 6.0 requires VS 16.11.
Strictly speaking VS isn't not need to build from command line (I think it is needed for VC++ projects, but C++ isn't essential for your changes). Both build.cmd and restore.cmd download the required version of .NET 6.0 nightlies. The build procedure is described in the docs.

[Balkoth]

So today i took the chance to give building winforms another try, and finally succeeded....
I did the changes mentioned here earlier, so feel free to review now.

[RussKie]

👍
We just need to add a test.

Please have a look at the docs and at ToolStrip_RendersBackgroundCorrectly, it should be reasonably straight forward to add a test to assert the border colour.

[Balkoth]

Relocated the API changes, and added a rendering test for the border color.

[RussKie]

🚀 LGTM

[RussKie]

@Balkoth a friendly nudge. If you think it is ready, set it ready for review, so we can take it. The 6.0 branches are getting closed in few days.

[RussKie]

Please rebase and resolve the MC. Thanks

[Balkoth]

Rebased. What is the MC and how do i resolve it?

[RussKie]

MC stands for "merge conflict". Looks like your rebase didn't quite work, the build is failing.

D:\workspace\_work\1\s\src\System.Windows.Forms\src\PublicAPI.Unshipped.txt(1,1): error RS0025: The symbol '~override System.Windows.Forms.TrackBar.CreateAccessibilityInstance() -> System.Windows.Forms.AccessibleObject' appears more than once in the public API files. [D:\workspace\_work\1\s\src\System.Windows.Forms\src\System.Windows.Forms.csproj]
##[error]src\System.Windows.Forms\src\PublicAPI.Unshipped.txt(1,1): error RS0025: (NETCORE_ENGINEERING_TELEMETRY=Build) The symbol '~override System.Windows.Forms.TrackBar.CreateAccessibilityInstance() -> System.Windows.Forms.AccessibleObject' appears more than once in the public API files.

Build FAILED.

[Balkoth]

Done.

[RussKie]

Thank you