Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip TextRenderer asserts #4901

Merged
merged 1 commit into from
May 13, 2021
Merged

Allow to skip TextRenderer asserts #4901

merged 1 commit into from
May 13, 2021

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented May 13, 2021

While painting LinkedLabel we modify device context before drawing the
label's text. Because of that we hit the asserts in TextRenderer.GetApplyStateFlags.
Since the DC state is expected, skip the assertions.

Closes #4857

Microsoft Reviewers: Open in CodeFlow

While painting LinkedLabel we modify device context before drawing the
label's text. Because of that we hit the asserts in TextRenderer.GetApplyStateFlags.
Since the DC state is expected, skip the assertions.

Closes dotnet#4857
@RussKie RussKie requested a review from a team as a code owner May 13, 2021 11:57
@ghost ghost assigned RussKie May 13, 2021
@RussKie RussKie requested a review from JeremyKuhne May 13, 2021 11:58
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RussKie
Copy link
Member Author

RussKie commented May 13, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@RussKie RussKie merged commit e9e8d8f into dotnet:main May 13, 2021
@RussKie RussKie deleted the fix_4857 branch May 13, 2021 23:31
@ghost ghost added this to the 6.0 Preview5 milestone May 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinkedLabel.PaintLink doesn't preserve clipping/transform
3 participants