Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates to use ApplicationConfiguration.Initialize() #5530

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Aug 25, 2021

Relates to #5035
Relates to #5071

Proposed changes

Regression?

  • No, new functionality

Risk

  • Minimal

Test methodology

Manually create various apps and verify the expected content

dotnet new -i C:\Development\winforms\pkg\Microsoft.Dotnet.WinForms.ProjectTemplates\content\WinFormsApplication-CSharp
cd .. && md template1 && cd template1 && dotnet new winforms  && code . 
cd .. && md template2 && cd template2 && dotnet new winforms -f net6.0 && code . 
cd .. && md template3 && cd template3 && dotnet new winforms -f net5.0 && code . 
cd .. && md template4 && cd template4 && dotnet new winforms -f netcoreapp3.1 && code . 
Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie requested a review from a team as a code owner August 25, 2021 08:20
@ghost ghost assigned RussKie Aug 25, 2021
@RussKie RussKie added Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria area-Templates Servicing-approved .NET Shiproom approved the PR for merge and removed Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels Aug 25, 2021
@RussKie
Copy link
Member Author

RussKie commented Aug 25, 2021

Approved over email

@RussKie RussKie force-pushed the update_template_for_ApplicationConfiguration_2 branch from 4dc3f70 to 5a93314 Compare August 26, 2021 00:08
@RussKie RussKie changed the base branch from release/6.0 to release/6.0-rc1 August 26, 2021 00:08
@RussKie RussKie merged commit dc6a62a into dotnet:release/6.0-rc1 Aug 26, 2021
@RussKie RussKie deleted the update_template_for_ApplicationConfiguration_2 branch August 26, 2021 00:46
@RussKie RussKie added this to the 6.0 rc1 milestone Aug 26, 2021
@dotnet dotnet locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Templates Servicing-approved .NET Shiproom approved the PR for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant